Merged
Conversation
🦋 Changeset detectedLatest commit: 547e238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 42.82% 42.62% -0.20%
==========================================
Files 1125 1128 +3
Lines 49360 49804 +444
Branches 11274 11386 +112
==========================================
+ Hits 21137 21231 +94
- Misses 28153 28503 +350
Partials 70 70
|
53dd1b5 to
4f77814
Compare
48 tasks
d8d09da to
1b2eaf9
Compare
80ce964 to
431bf38
Compare
431bf38 to
547e238
Compare
akphi
approved these changes
May 9, 2022
packages/legend-graph/src/graphManager/action/changeDetection/Data_ObserverHelper.ts
Show resolved
Hide resolved
packages/legend-graph/src/graphManager/action/changeDetection/Test_ObserverHelper.ts
Show resolved
Hide resolved
akphi
reviewed
May 9, 2022
packages/legend-graph/src/models/metamodels/pure/test/assertion/status/AssertFail.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/EqualTo.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/EqualToTDS.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/TestAssertion.ts
Show resolved
Hide resolved
packages/legend-studio/src/components/editor/side-bar/testable/TestableManager.tsx
Show resolved
Hide resolved
Contributor
|
Left reviews to clean this up since we need to merge this to unblock development. Comments are mostly about cosmetics. The only really major thing is I don't fully grasp why we complicate the extension mechanism, so we should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to: #1077
Version V0 of testable manager.
With this PR, Users can define testable tests in
text mode. This includes ones with relational data.Run the tests via the testable manager on the side bar. View failing tests (expected <-> actual) data.
Yet to implement: Testable Editors
Depended on release finos/legend-engine#658 to work but is backward compatible.
How did you test this change?
testable.mp4
TESTDATA FOR VIDEO